Replace stale "issue #23" ref in TryAddProbeCountTests docstring - #75
Merged
marius-bughiu merged 1 commit intoMay 11, 2026
Merged
Conversation
The class docstring described itself as "Regression tests for issue #23", referencing the original internal ISSUES.md numbering used before the backlog was migrated to GitHub Issues (commit 0f84d86). On GitHub, issue #23 is now "Add SIMD optimizations" -- unrelated -- so the existing pointer sends a curious reader to the wrong place. Replace the dead reference with a pointer to PR #53, which is where the single-probe TryAdd rewrite actually landed and which holds the rationale in its description. Comment-only change; no behaviour or test logic affected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
marius-bughiu
added
the
automated:code-review
marius-bughiu
deleted the
chore/code-review/fix-stale-issue-ref-in-tryadd-probe-tests
branch
July 24, 2026 22:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the class docstring on
TryAddProbeCountTeststo point at PR #53 instead of "issue #23". One-line comment edit; no test or production behaviour change.Why
The docstring previously read "Regression tests for issue #23". That number was an internal
ISSUES.mdreference, used before the backlog was migrated to GitHub Issues (commit0f84d86). On GitHub today, #23 is "Add SIMD optimizations" — a different and currently-open piece of work. A reader who follows the cross-reference lands on a totally unrelated topic.The single-probe
TryAddrewrite that this test class actually pins landed in PR #53, and that PR's description is the right place to send a curious reader.Test plan
dotnet build— clean (0 errors, pre-existing 50 warnings unchanged).dotnet test— not strictly needed; this is a comment-only change. Will run if CI requests.